Skip to content

PHP 8 support #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2021
Merged

PHP 8 support #7

merged 7 commits into from
Mar 17, 2021

Conversation

tanerkay
Copy link
Contributor

@tanerkay tanerkay commented Jan 10, 2021 •
edited
Loading

Q A
New Feature yes

Description

Addresses #6

Caveats:

  • waiting on two upstream dependencies for PHP 8 support:
    • laminas/laminas-math
    • laminas/laminas-recaptcha

@tanerkay tanerkay changed the title #6 PHP 8 support PHP 8 support Jan 10, 2021
froschdesign
froschdesign reviewed Jan 11, 2021
View reviewed changes
@froschdesign
Copy link
Member

froschdesign commented Jan 11, 2021 •
edited
Loading

@tanerkay
Thanks for your contribution! 👍

waiting on two upstream dependencies for PHP 8 support…

In the meantime you can fix some other problems like:

PHP Fatal error:  Declaration of LaminasTest\Captcha\ImageTest::tearDown() must be compatible
with PHPUnit\Framework\TestCase::tearDown(): void
in /home/travis/build/laminas/laminas-captcha/test/ImageTest.php on line 65

https://travis-ci.com/github/laminas/laminas-captcha/jobs/470269060#L473

Thanks in advance!

@froschdesign froschdesign linked an issue Jan 11, 2021 that may be closed by this pull request
PHP 8.0 support #6
Closed
6 tasks
froschdesign
froschdesign reviewed Jan 12, 2021
View reviewed changes
@sivaschenko
Copy link

sivaschenko commented Mar 11, 2021 •
edited
Loading

Hi @tanerkay @froschdesign are there any expectation when the PHP 8 support could be available?

Looks like laminas/laminas-math is already compatible with PHP 8
And laminas/laminas-recaptcha#5 is ready as well

@sivaschenko sivaschenko mentioned this pull request Mar 11, 2021
Closed
@weierophinney weierophinney added this to the 2.9.0 milestone Mar 17, 2021
@weierophinney
qa: remove obsolete CI configuration
6868ba6 
All of it targetted PHP versions prior to 7.3.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney weierophinney mentioned this pull request Mar 17, 2021
Closed
@weierophinney
qa: update composer lockfile
0c2f53a 
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney weierophinney merged commit f4a398c into laminas:2.9.x Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign left review comments

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
4 participants
@tanerkay @froschdesign @sivaschenko @weierophinney