Added Success/NoSuccess results for GenServer init #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
approved these changes
Jul 29, 2025
Contributor
juan518munoz
left a comment
juan518munoz
left a comment
There was a problem hiding this comment.
Looks ok on my side, maybe we should try to add a test that verifies this works as expected.
fedacking
approved these changes
Jul 29, 2025
github-merge-queue bot
pushed a commit
to lambdaclass/ethrex
that referenced
this pull request
Aug 4, 2025
**Motivation** Error lines in spawned logs [were muted](#3467) because there was a lot of spam regarding failed connections and handshakes. That was not safe as other important problems may get muted too. **Description** This PR handles the connection errors on handshake and initialization and logs a lower priority log line (debug) as it is pretty common. It also reverts the log directive to mute spawned initialization errors. it requires [spawned 0.2.2](lambdaclass/spawned#39). Closes #3472
LeanSerra
pushed a commit
to lambdaclass/ethrex
that referenced
this pull request
Aug 12, 2025
**Motivation** Error lines in spawned logs [were muted](#3467) because there was a lot of spam regarding failed connections and handshakes. That was not safe as other important problems may get muted too. **Description** This PR handles the connection errors on handshake and initialization and logs a lower priority log line (debug) as it is pretty common. It also reverts the log directive to mute spawned initialization errors. it requires [spawned 0.2.2](lambdaclass/spawned#39). Closes #3472
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Error lines in spawned logs [were muted](lambdaclass#3467) because there was a lot of spam regarding failed connections and handshakes. That was not safe as other important problems may get muted too. **Description** This PR handles the connection errors on handshake and initialization and logs a lower priority log line (debug) as it is pretty common. It also reverts the log directive to mute spawned initialization errors. it requires [spawned 0.2.2](lambdaclass/spawned#39). Closes lambdaclass#3472
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.