Skip to content

fix(l1): headers snapsync logs #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(l1): headers snapsync logs #5082

wants to merge 10 commits into from
+21 −22

Conversation

@fedacking
Copy link
Contributor

@fedacking fedacking commented Oct 28, 2025 •
edited
Loading

Motivation

The logs for the headers in snapsync shows inaccurate numbers due to the chunked header download. This pr aims to fix that and show the proper percentage of headers to download.

Description

  • Change METRICS.headers_downloaded to an IntCounter instead of AtomicU64
  • Removed METRICS.headers_to_download and replaced the calculation with METRICS.sync_head_block
  • Fixed METRICS.sync_head_block to include the proper

Works to improve #4950

@fedacking fedacking requested a review from a team as a code owner October 28, 2025 16:03
@github-actions github-actions bot added the L1 Ethereum client label Oct 28, 2025
@fedacking fedacking mentioned this pull request Oct 28, 2025
Open
21 tasks
@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Lines of code report

Total lines added: 7
Total lines removed: 10
Total lines changed: 17

Detailed view 
+----------------------------------------------+-------+------+
| File                                         | Lines | Diff |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/metrics.rs      | 599   | +6   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/network.rs      | 364   | +1   |
+----------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/peer_handler.rs | 1753  | -10  |
+----------------------------------------------+-------+------+

pablodeymo
pablodeymo reviewed Oct 28, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablodeymo pablodeymo pablodeymo left review comments

@jrchatruc jrchatruc jrchatruc approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@fedacking fedacking

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fedacking @pablodeymo @jrchatruc