chore(l1): fixed data path for mac #5075
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedacking
changed the title
MegaRedHand
reviewed
Oct 27, 2025
tooling/sync/Makefile
Outdated
| OS = $(shell uname) | ||
| ifeq ($(OS), Darwin) | ||
| DATA_PATH = $(HOME)/Library/Application\ Support | ||
| DATA_PATH = $(HOME)/Library/Application Support |
There was a problem hiding this comment.
Don't we need to add quotes around this too?
There was a problem hiding this comment.
No, this gets added to the variable in it's entirety
There was a problem hiding this comment.
Any reason you chose this specific path? I know it's the default, but maybe for tooling we can just choose a simpler path so we don't have to do this weird logic with having different paths depending on the OS
There was a problem hiding this comment.
Changed the DATA_PATH only Library to simplify the tooling makefile in 6e417cc
mpaulucci
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The MacOS default path includes a space in the path for "Application Support". If a user in MacOS runs the tooling links will fail due to the space in the path, and the '' will cause issues.
Description