Reduce front/app bundle size #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillro
previously approved these changes
Jul 8, 2021
auto-merge was automatically disabled
July 8, 2021 10:02
Pull request was converted to draft
giuseppedeponte
changed the title
giuseppedeponte
force-pushed
the
gdp/remove-react-spring-from-app-chunk
branch
from
2c2c7db to
d9c591a
Compare
jillro
reviewed
Jul 8, 2021
Il a déjà disparu, c'était juste du code mort |
jillro
approved these changes
Jul 8, 2021
|
C'est top, c'est vraiment un gros gros gain. |
auto-merge was automatically disabled
July 8, 2021 14:31
Pull request was converted to draft
jillro
approved these changes
Jul 8, 2021
maxGoaz
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En vrai react-spring ne semble pas être le problème plus gros de ce bundle :
polishedqu'on utilisait très peuTout ça fait passer le bundle de 1.09Mb à 781 Kb - je ne suis pas sûr qu'on puisse supprimer beaucoup plus.
La plus grosse dépendance est maintenant Sentry, mais ils ont promis de reduire la taille de leur bundle dans la version 7 (cf. getsentry/sentry-javascript#2707).