feat(middleware): add Deflate middleware #2085
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
- Coverage 92.21% 92.18% -0.03%
==========================================
Files 37 37
Lines 3019 3034 +15
==========================================
+ Hits 2784 2797 +13
- Misses 148 150 +2
Partials 87 87
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Deflate middleware which is very similar to the current Gzip middleware's implementation, I think it will be nice to have deflate as well if someone also needs it.
I didn't change any public function and struct in
compress.go, and didn't touch existing test cases incompress_test.goas well, so I think this PR won't break backward compatibility.