modify enable/disable definition for Trigger #93
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added additional logic to modify how enable() and disable() are defined for a Trigger.
To illustrate, here is a use case:
So I would then instantiate my Trigger as
Trigger(..., inverted=True, trigger_edge_type='rising')
so that it matches with my TriggerableDevice.This seems to make sense, if this was the intended use case of the
inverted
argument. This is less misleading than usingtrigger_edge_type='falling'
for both Trigger and TriggerableDevice, which is a (working) workaround. However, merging this would break the workaround.