Allow passthrough of other kwargs in DDS gate DigitalOut specification. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, this allows for the digital gate to have inverted logic.
|
Probably should have done this before v3.3.0, but oh well. Better late than never. |
dihm
added a commit
that referenced
this pull request
Aug 22, 2023
commit e2a992d028dd505b56eb5d84db8cc0c055221743 Author: David Meyer <[email protected]> Date: Tue Aug 22 15:30:36 2023 -0400 Merge pull request #101 from dihm/dtype_hotfix Fix bad np.array call in `Output.expand_timeseries` commit 20577d18ab9276dee33e7a2c89787221580f10e0 Author: David Meyer <[email protected]> Date: Wed Apr 12 21:35:18 2023 -0400 Merge pull request #89 from dihm/dds_gate_kwargs Allow passthrough of other kwargs in DDS gate DigitalOut specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, this allows for the digital gate of a DDS Quantity to have inverted logic.