Skip to content

Conversation

@dihm
Copy link
Contributor

@dihm dihm commented Aug 3, 2025

Bump pins and refresh build

See labscript-suite/labscript-suite#97 for details

@dihm
Copy link
Contributor Author

dihm commented Aug 3, 2025

It would appear that labscript.core is not building correctly

@dihm
Copy link
Contributor Author

dihm commented Aug 19, 2025

After some more digging, it appears that autosummary is not recursing properly for any submodule. Existing functionality is intersphinx mapping to the current online docs, which is obviously an issue as it makes the docs builds very circular.

Edit: this appears to be an issue with all labscript suite docs builds that use autosummary recursive calls. Just didn't notice until this package. Ugh. Includes runmanager, labscript-utils, blacs, and lyse.

@dihm
Copy link
Contributor Author

dihm commented Aug 19, 2025

We are back at labscript.core not building correctly. After some debugging, this appears to be some an interaction with numpy=2. With at least numpy=2.3 installed, the labscript.core submodule is getting replaced by the numpy.core module on import.

>>>import labscript
>>>print('IntermediateDevice' in dir(labscript))
True
>>>print('IntermediateDevice' in dir(labscript.core))
False
>>> print(dir(labscript.core) == dir(numpy.core))
True
>>>print(labscript.core.__all__ == numpy.core.__all__)
True

Doing some investigation, this is due to the from pylab import * in labscript.labscript clobbering the core module attribute. The contents of labscript.core still import correctly to the parent level namespace thanks to relative imports (from .core import xxxx).

This works around `labscript.core` clobbering from the `pylab` star importing
`numpy.core` into the same namespace.
@dihm
Copy link
Contributor Author

dihm commented Aug 19, 2025

Going to work around this for now by pinning numpy<2 for docs building.

@dihm dihm merged commit 8d2e773 into labscript-suite:master Aug 19, 2025
1 check passed
@dihm dihm deleted the sphinx_update branch August 19, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants