Skip to content

Conversation

@andrzej-bieniek
Copy link
Contributor

I can add Settings option if it is something that you would merge in.

@nguillaumin
Copy link
Contributor

Sounds like a good idea, however I have a few remarks with your current implementation:

  • Please stick to the existing coding conventions (brackets on the same line for example)
  • You'll have to account for the database upgrade, i.e. people that will upgrade to the newest version of OSMTracker needs to get their database upgraded with the new column. You can see how it has been done before in DatabaseHelper.java, you need to increase the version number and add the code to add the column.

I'm happy for it to be the default without a setting, I don't think that will cause any trouble.

Cheers.

@andrzej-bieniek
Copy link
Contributor Author

Thank you for comments, I will add changes.

Regarding GPX file.
Alternative to speed extension field is to store file in GPX 1.0 format [1](it has speed field in specified).
Advantage would be that parsers/applications out there (e.g. [2]) will be able to use speed tag.
Extensions in GPX 1.1 are not standardised, so speed will need software change to be accessible.

There are quite a lot of posts on gpsxml yahoo group regarding speed tag, piking up a short ones [3] and [4].

I think I would be keen to add ability to store in 1.0 format (as an option) to avoid confusion.
Please let me know if it sounds ok?

Thanks.

[1] http://www.topografix.com/gpx_manual.asp
[2] https://github.com/tkrajina/gpxpy
[3] http://tech.groups.yahoo.com/group/gpsxml/message/2250
[4] http://tech.groups.yahoo.com/group/gpsxml/message/2107

@nguillaumin
Copy link
Contributor

Sorry for the delay, I just merged your change.
I'm not keen on going to GPX 1.0 as it's a deprecated format...

nguillaumin pushed a commit that referenced this pull request Aug 31, 2013
… into andyhelp-master

[pull #32] Updated tests for new <speed> tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants