Skip to content

Conversation

yuji38kwmt
Copy link
Collaborator

No description provided.

@yuji38kwmt yuji38kwmt enabled auto-merge (squash) September 11, 2025 05:22
@kci-pr-agent
Copy link

kci-pr-agent bot commented Sep 11, 2025

Title

Typoe fix


Description

  • Update ruff version constraint in pyproject.toml

  • Add UP045 and RUF059 rules to linter config

  • Remove inline ruff noqa E501 from dataclass files

  • Fix typo in generate/README.md


Changes walkthrough 📝

Relevant files
Configuration changes
input.py
Remove inline ruff noqa directive                                               

annofabapi/dataclass/input.py

  • Removed # ruff: noqa: E501 comment
+0/-1     
job.py
Remove inline ruff noqa directive                                               

annofabapi/dataclass/job.py

  • Removed # ruff: noqa: E501 comment
+0/-1     
organization.py
Remove inline ruff noqa directive                                               

annofabapi/dataclass/organization.py

  • Removed # ruff: noqa: E501 comment
+0/-1     
supplementary.py
Remove inline ruff noqa directive                                               

annofabapi/dataclass/supplementary.py

  • Removed # ruff: noqa: E501 comment
+0/-1     
pyproject.toml
Update linter dependencies and rules                                         

pyproject.toml

  • Bumped ruff version constraint
  • Added UP045 to ignore list
  • Added RUF059 to select list
  • +3/-1     
    Documentation
    README.md
    Fix typo in README documentation                                                 

    generate/README.md

    • Corrected "Path Prameters" to "Path Parameters"
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @yuji38kwmt yuji38kwmt merged commit 40abc47 into main Sep 11, 2025
    7 checks passed
    @yuji38kwmt yuji38kwmt deleted the typoe-fix branch September 11, 2025 05:22
    @kci-pr-agent
    Copy link

    kci-pr-agent bot commented Sep 11, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    リンター設定修正確認

    '# ruff: noqa: E501' の削除により行長チェックが有効化されます。意図した結果かどうか、既存コードで問題が発生しないか確認してください。

    # pylint: disable=too-many-lines,trailing-whitespace
    
    """
    annofabapiのmodelをDataClassで定義したクラス
    ドキュメント構文確認

    箇条書きのインデントやマークダウン構文が他の項目と整合しているか確認してください。

    * Path Parametersの中身を引数にする。
    ruffバージョン互換性

    ruffのバージョン指定を ">=0.12" のみとした場合、上限なしで予期せぬマイナーバージョンアップが影響しないか確認してください。

    "ruff>=0.12 ; python_version >= '3.12'",

    @kci-pr-agent
    Copy link

    kci-pr-agent bot commented Sep 11, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant