差し戻された際のタスク履歴を特定するutilを作成しました #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a utility function to determine which task history indices indicate a rejection event when a task is sent back, along with corresponding tests and a new dependency.
- Added a new util function (find_rejected_task_history_indices) to identify rejected task histories.
- Developed unit tests to verify the utility's behavior.
- Added the isodate dependency to support duration parsing.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| annofabapi/util/task_history.py | Added the rejection-determining utility function. |
| tests/util/test_local_task_history.py | Introduced tests for the new function to verify expected rejection indices. |
| pyproject.toml | Added the isodate dependency required by the new util function. |
Files not reviewed (1)
- docs/api_reference/util.rst: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
タスク履歴には、「どのタスク履歴で差し戻されたか」の情報がないため、それを算出するutils関数を作成しました。