Aggregate failed workload conditions into CR #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Kalenyuk <[email protected]>
kubevirt-bot
added
dco-signoff: yes
akalenyu
force-pushed
the
report-degraded
branch
5 times, most recently
from
e9ccdd6 to
519ef97
Compare
akalenyu
force-pushed
the
report-degraded
branch
from
519ef97 to
e689fd4
Compare
Contributor
Author
|
/retest |
akalenyu
force-pushed
the
report-degraded
branch
from
e689fd4 to
b0d89ad
Compare
Contributor
Author
|
/test all |
|
@akalenyu: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
/test all |
1 similar comment
Contributor
Author
|
/test all |
akalenyu
force-pushed
the
report-degraded
branch
from
ded2113 to
3b5e705
Compare
Broke after we bumped and got kubernetes-sigs/controller-runtime#1399 Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
force-pushed
the
report-degraded
branch
from
3b5e705 to
407ea84
Compare
Contributor
Author
|
/cc @mhenriks @tiraboschi |
Member
|
/lgtm |
kubevirt-bot
added
lgtm
tiraboschi
approved these changes
Mar 20, 2023
mhenriks
approved these changes
Mar 20, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akalenyu, mhenriks, tiraboschi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we just dangle in
Deployingphase when things go badly, althoughthe deployment conditions API provides more information such as
Progressing=falsethat we can use to better capture the status of install.