Skip to content

proposal: use strong types for events #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
matthyx wants to merge 219 commits into
base: main
Choose a base branch
from
Draft

proposal: use strong types for events #656

matthyx wants to merge 219 commits into from

Conversation

@matthyx
Copy link
Contributor

@matthyx matthyx commented Oct 25, 2025

No description provided.

afek854 and others added 30 commits July 24, 2025 13:52
@afek854
added interfaces for rule manager refactor
d5be2e9 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
added structure
eddcef6 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
added profile validator
f350c8a 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
added v1
531da25 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
added profile validators
a0c3245 
Signed-off-by: Afek Berger <afekb@armosec.io>
@amitschendel
go mod tidy
d2c6899 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Adding base helpers pkg
13331e4 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@afek854
added rule failure creator and changed rule_manager logic
92cd0b2 
Signed-off-by: Afek Berger <afekb@armosec.io>
@amitschendel
Adding lib
9c36107 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Caching programs
021a6aa 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@afek854
integrate new rule manager
197b7da 
Signed-off-by: Afek Berger <afekb@armosec.io>
@amitschendel
Merge branch 'feature/refactor_rule_engine' into dev/rre
c9f6110 
Signed-off-by: Amit Schendel <58078857+amitschendel@users.noreply.github.com>
@amitschendel
Resolving conflicts
cfab916 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Adding crd
151c993 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Dev/rre (#594)
7a9f009 
* go mod tidy

Signed-off-by: Amit Schendel <amitschendel@gmail.com>

* Adding base helpers pkg

Signed-off-by: Amit Schendel <amitschendel@gmail.com>

* Adding lib

Signed-off-by: Amit Schendel <amitschendel@gmail.com>

* Caching programs

Signed-off-by: Amit Schendel <amitschendel@gmail.com>

* Resolving conflicts

Signed-off-by: Amit Schendel <amitschendel@gmail.com>

* Adding crd

Signed-off-by: Amit Schendel <amitschendel@gmail.com>

---------

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <58078857+amitschendel@users.noreply.github.com>
@afek854
organized imports
289e81a 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
added watcher & tests
9edf8c5 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
added watcher and integration with binding
001c265 
Signed-off-by: Afek Berger <afekb@armosec.io>
@amitschendel
Changing types
c62f51b 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Defining types
ffc45cf 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Fixing code
a0c86a9 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@afek854
merged
4e297ae 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
fixed container name
62e82bf 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
fixed conflicts
e79fd44 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
separated mock
f1419d2 
Signed-off-by: Afek Berger <afekb@armosec.io>
@afek854
fixed watcher & create event with check struct
e719619 
Signed-off-by: Afek Berger <afekb@armosec.io>
@amitschendel
Changing event
8cf32cf 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Updating code
9550178 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@afek854
modify cel arguments & events check struct
dce926b 
Signed-off-by: Afek Berger <afekb@armosec.io>
@amitschendel
Adding some code
efd6a1e 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
matthyx and others added 18 commits October 22, 2025 17:56
@matthyx
do not fail test if PrintAppLogs finds no pod
7c685f5 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
fix syscall callbacks by using new events
c761a31 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
adding logs for processtree test
d008000 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@amitschendel
Removing event from stdout and http logs
6d530d2 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Adding tracers
8575bdb 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Adding new rules
6635584 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Adding new exit fields
9b43b2d 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@matthyx
add log for exec event
434ea0b 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@amitschendel
Adding some types
de07c49 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Merge branch 'feature/ebpf-ibg' of github.com:kubescape/node-agent in…
c157839 
…to feature/ebpf-ibg
@amitschendel
Adding buffer for container eol notifications
1ba467c 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
Fixing config test
a93d1fe 
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@matthyx
print logs of process-tree pod after test 24
b78df2e 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
increase waiting time for alerts
2d5947a 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
increase map-fetch-interval for syscall tracer
e270455 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
refactor: update process event handling and clean up unused methods
b0f4778 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
try to avoid race in AlertManagerExporter
4b41532 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
proposal: use strong types for events
90b6d1c 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx requested a review from amitschendel October 25, 2025 15:45
@github-actions
Copy link

github-actions bot commented Oct 25, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

Base automatically changed from feature/ebpf-ibg to image-based-full October 27, 2025 13:57
@matthyx matthyx moved this to WIP in KS PRs tracking Oct 28, 2025
@matthyx matthyx force-pushed the image-based-full branch 4 times, most recently from 3b263b7 to 9b21531 Compare November 3, 2025 08:05
Base automatically changed from image-based-full to feature/refactor_rule_engine December 18, 2025 12:05
Base automatically changed from feature/refactor_rule_engine to main December 18, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amitschendel amitschendel Awaiting requested review from amitschendel

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

KS PRs tracking
Status: WIP

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthyx @afek854 @amitschendel