Skip to content

Conversation

@zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Jul 12, 2018

🚨 THIS PR MUST BE MERGED MANUALLY 🚨

This PR updates the OWNERS file for previous, pre-Prow releases of Kubernetes.

Right now, OWNERS files in branches release-1.7 through release-1.9 only list reviewers. Because there are no approvers in the OWNERS file, this makes it impossible to approve changes to those branches using Prow.

While technically we don't accept changes to deprecated branches, this PR solves a problem that would prevent merging fixes for critical/security issues.

Related PRs:

Branch PR
release-1.7 #9490
release-1.8 #9492
release-1.9 #9491

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

If they are not already assigned, you can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for k8sio-v1-9 ready!

Built with commit ad729cd

https://deploy-preview-9491--k8sio-v1-9.netlify.com

@zacharysarah zacharysarah changed the title Backport OWNERS from master to release-1.9 Update OWNERS from master to release-1.9 Jul 12, 2018
@zacharysarah zacharysarah changed the title Update OWNERS from master to release-1.9 Update OWNERS for 1.9 Jul 12, 2018
@kbarnard10
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2018
@zacharysarah zacharysarah merged commit b623b38 into kubernetes:release-1.9 Jul 12, 2018
@zacharysarah zacharysarah deleted the 1.9-OWNERS-update branch July 12, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants