Skip to content

Conversation

@zacharysarah
Copy link
Contributor

This PR fixes some 1.9 navigation elements overlooked by #9071:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jul 11, 2018

Deploy preview for k8sio-v1-9 ready!

Built with commit 10b7956

https://deploy-preview-9473--k8sio-v1-9.netlify.com

@zacharysarah
Copy link
Contributor Author

See #9357 (comment) for discussion about Travis failing.

@tengqm
Copy link
Contributor

tengqm commented Jul 12, 2018

This looks like the same problem #9423 is fixing.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2018
@zacharysarah
Copy link
Contributor Author

@tengqm It is, for release-1.9. Do I need to update this PR with the fix from #9423?

@tengqm
Copy link
Contributor

tengqm commented Jul 12, 2018

@zacharysarah At least the k8s.io/kubernetes/pkg/scheduler/api/latest path needs a change. It has been relocated upstream.

@tengqm
Copy link
Contributor

tengqm commented Jul 12, 2018

@zacharysarah Please try modify line 52 of test/examples_test.go from
schedulerapilatest "k8s.io/kubernetes/pkg/scheduler/api/latest"
to
schedulerapilatest "k8s.io/kubernetes/plugin/pkg/scheduler/api/latest"

Update 1.10 path

Trying to debug Travis CI failure

Update test case from #9423

Updating 1.9 navigation

Update 1.10 path

Trying to debug Travis CI failure

Update from #9423

1.9, not 1.8
@zacharysarah
Copy link
Contributor Author

zacharysarah commented Jul 12, 2018

@tengqm I changed too many things in examples_test.go at once--I'll regress and try them one at a time.

UPDATE: Actually, before I do anything else, here's what I did: I imported the changes to examples_test.go from #9423. Here's the output:

package k8s.io/kubernetes/pkg/api/validation: cannot find package "k8s.io/kubernetes/pkg/api/validation" in any of:
	/home/travis/.gimme/versions/go1.8.3.linux.amd64/src/k8s.io/kubernetes/pkg/api/validation (from $GOROOT)
	/home/travis/gopath/src/k8s.io/kubernetes/pkg/api/validation (from $GOPATH)

The command "go get -t -v k8s.io/website/test" failed and exited with 1 during .

@zacharysarah
Copy link
Contributor Author

@tengqm Looks like you fixed it! Feel free to lgtm/approve if you like it otherwise. 👍

@tengqm
Copy link
Contributor

tengqm commented Jul 13, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2018
@tengqm tengqm changed the title [WIP] Updating 1.9 navigation Updating 1.9 navigation Jul 19, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 585aa03 into kubernetes:release-1.9 Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants