-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Container build: use npm ci over packages files and fix build cmd #48741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container build: use npm ci over packages files and fix build cmd #48741
Conversation
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
7e6f74a to
9d1d332
Compare
|
/cc @nate-double-u |
|
I have verified in my local env that the |
|
I'll take the LGTM from #48741 (comment) as confirmation this works better than it did. /lgtm |
|
LGTM label has been added. Git tree hash: 3d7128f6d5631f4b7a19766565bbb0bba7cbf6ce
|
|
I confirm this corrects the build issue. Thanks @chalin /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nate-double-u The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In addition to fixing the issue named below, this PR has the container use the project's specified NPM dependencies, rather than using a separate list, keeping things DRY.
make container-buildcommand fails #48739package.json package-lock.jsonfilesnpm ci... so that Hugo commands from the container use the same NPM packages we do in local development.container-build, and changes the command so that it writes to the localpublicfolder, making it easier to debug generated files (without this change, the container build command fails because it can't write to./public-- which means the only other alternative would be to write to another container-only folder such as/tmp/public, but I think that the solution proposed here is better).