add a new blog for etcd learner mode usage in kubeadm join #43095

pacoxu · 2023-09-18T08:32:50Z

netlify · 2023-09-18T08:48:31Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`59791fd`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65080b343ef2b30008e3889c
😎 Deploy Preview	https://deploy-preview-43095--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-09-18T08:54:54Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`764487f`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/650d24fb647c3b00084bcc5f
😎 Deploy Preview	https://deploy-preview-43095--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

windsonsea

Pick some style issues.

content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md

neolit123

SGTM, thanks for the blog!

content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md

neolit123 · 2023-09-18T10:01:45Z

content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md

+
+### Join Nodes to the ETCD Learner Mode Cluster
+
+Before joining a node to the ETCD learner mode cluster, ensure that the control plane nodes and


Suggested change

Before joining a node to the ETCD learner mode cluster, ensure that the control plane nodes and

Before joining a worker node to the ETCD learner mode cluster, ensure that the control plane nodes and

?

Before joining a control-plane node to the etcd learner mode cluster, ensure that the control plane nodes
and all etcd members are healthy.

Before joining a worker node to the etcd learner mode cluster, ensure that the control plane nodes are healthy.

sftim

Thanks for the PR.

Here's some more feedback. I suggest pushing the publication date back a few days to allow time for reviews etc. Please pick a weekday.

sftim · 2023-09-18T11:38:55Z

content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md

+
+**Author:** Paco Xu (DaoCloud)
+
+Kubeadm now supports etcd learner mode, which allows you to enhance the resilience and stability


Suggested change

Kubeadm now supports etcd learner mode, which allows you to enhance the resilience and stability

The [`kubeadm`](/docs/reference/setup-tools/kubeadm/) tool now supports etcd learner mode, which

allows you to enhance the resilience and stability

(main aim here is to use the correct case, “kubeadm” not “Kubeadm”).

I changed the title as well. Is that OK?

content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md

sftim · 2023-09-18T11:50:53Z

content/en/blog/_posts/2023-09-20-kubeadm-use-etcd-learner-mode.md

Overall, I think it'd be useful to show more detail about adding nodes. I would:

also mention that there should be an odd number of control plane nodes (eventually! - it's OK to briefly have an even number during cluster setup)

make it clear that the etcd cluster is stacked onto the control plane nodes

explain what shell command lets you check that etcd is healthy and that a second, third control plane node has joined OK

explain what shell commend lets you check that the Kubernetes level control-plane aspects are healthy before you add another control plane node

Maybe also:

mention that adding worker nodes is almost exactly the same as before, and is included for completeness

Add some etcd cluster check related intro in bf6c784

pacoxu · 2023-09-19T06:03:04Z

Thanks for the details comments and more detail suggestions.

Here's some more feedback. I suggest pushing the publication date back a few days to allow time for reviews etc. Please pick a weekday.

I changed it to next Monday.

content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md

neolit123

tech content LGTM
thanks

content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md

pacoxu · 2023-09-22T05:40:32Z

tech content LGTM
thanks

Updated. Thanks.

sftim · 2023-09-24T21:27:32Z

Thanks

/lgtm
/approve

(side note: this'll go out one day before “Happy 7th Birthday kubeadm”)

k8s-ci-robot · 2023-09-24T21:27:39Z

LGTM label has been added.

Git tree hash: 45497879d130f7f000dbe166511e8116f03e9d36

k8s-ci-robot · 2023-09-24T21:27:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/blog/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pacoxu · 2023-09-25T05:16:52Z

(side note: this'll go out one day before “Happy 7th Birthday kubeadm”)

🎉
Tomorrow is also the first day of kubecon China 2023(including kubernetes contributor summit).

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2023

k8s-ci-robot requested a review from nate-double-u September 18, 2023 08:32

k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Sep 18, 2023

k8s-ci-robot requested a review from onlydole September 18, 2023 08:32

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2023

pacoxu force-pushed the kubeadm-etcd-learner-mode branch from 59791fd to be97e51 Compare September 18, 2023 08:33

windsonsea reviewed Sep 18, 2023

View reviewed changes

neolit123 reviewed Sep 18, 2023

View reviewed changes

pacoxu force-pushed the kubeadm-etcd-learner-mode branch from be97e51 to 38f87b0 Compare September 18, 2023 10:22

sftim reviewed Sep 18, 2023

View reviewed changes

add a new blog for etcd learner mode usage in kubeadm join

bf6c784

pacoxu force-pushed the kubeadm-etcd-learner-mode branch from 38f87b0 to bf6c784 Compare September 19, 2023 05:12

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2023

SataQiu reviewed Sep 19, 2023

View reviewed changes

content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md Outdated Show resolved Hide resolved

content/en/blog/_posts/2023-09-25-kubeadm-use-etcd-learner-mode.md Outdated Show resolved Hide resolved

pacoxu force-pushed the kubeadm-etcd-learner-mode branch from 6a4b591 to d5b5b27 Compare September 21, 2023 10:46

pacoxu requested review from SataQiu, neolit123 and sftim September 22, 2023 03:52

neolit123 reviewed Sep 22, 2023

View reviewed changes

add some extra info about etcd cluster health check and join

764487f

pacoxu force-pushed the kubeadm-etcd-learner-mode branch from d5b5b27 to 764487f Compare September 22, 2023 05:24

k8s-ci-robot assigned sftim Sep 24, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2023

k8s-ci-robot merged commit 8662094 into kubernetes:main Sep 24, 2023

This was referenced Jan 29, 2024

sig-cl/kubeadm: Use etcd's learner mode kubernetes/enhancements#3614

Closed

RFE: use learner mode for joining etcd members kubernetes/kubeadm#1793

Closed


		### Join Nodes to the ETCD Learner Mode Cluster

		Before joining a node to the ETCD learner mode cluster, ensure that the control plane nodes and

	Before joining a node to the ETCD learner mode cluster, ensure that the control plane nodes and
	Before joining a worker node to the ETCD learner mode cluster, ensure that the control plane nodes and


		Author: Paco Xu (DaoCloud)

		Kubeadm now supports etcd learner mode, which allows you to enhance the resilience and stability

	Kubeadm now supports etcd learner mode, which allows you to enhance the resilience and stability
	The [`kubeadm`](/docs/reference/setup-tools/kubeadm/) tool now supports etcd learner mode, which
	allows you to enhance the resilience and stability

add a new blog for etcd learner mode usage in kubeadm join #43095

add a new blog for etcd learner mode usage in kubeadm join #43095

Uh oh!

Conversation

pacoxu commented Sep 18, 2023

Uh oh!

netlify bot commented Sep 18, 2023

✅ Pull request preview available for checking

Uh oh!

netlify bot commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

windsonsea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neolit123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

neolit123 Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

pacoxu Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

sftim Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

pacoxu Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sftim Sep 18, 2023

Choose a reason for hiding this comment

Uh oh!

pacoxu Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

pacoxu commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neolit123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pacoxu commented Sep 22, 2023

Uh oh!

sftim commented Sep 24, 2023

Uh oh!

k8s-ci-robot commented Sep 24, 2023

Uh oh!

k8s-ci-robot commented Sep 24, 2023

Uh oh!

pacoxu commented Sep 25, 2023

netlify bot commented Sep 18, 2023 •

edited

Loading

pacoxu Sep 19, 2023 •

edited

Loading

pacoxu commented Sep 19, 2023 •

edited

Loading