Skip to content

Conversation

@Okabe-Junya
Copy link
Member

@Okabe-Junya Okabe-Junya commented Oct 3, 2025

ref. kubernetes-sigs/contributor-playground#2177

What this PR does / why we need it:

  • to create some area/ labels for k-sigs/contributor-playground

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/label_sync Issues or PRs related to code in /label_sync sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 3, 2025
@Okabe-Junya Okabe-Junya marked this pull request as ready for review October 3, 2025 15:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2025
Copy link
Member

@Priyankasaggu11929 Priyankasaggu11929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Okabe-Junya, thank you so much for the PR.

I left 2 inline comments.

@Okabe-Junya Okabe-Junya force-pushed the add-label/k-sigs-contributor-playground branch from 4037daf to f62fbd8 Compare October 6, 2025 09:25
@Okabe-Junya
Copy link
Member Author

Thank you for your review, Priyankasaggu11929!
fixed all comments, so PTAL again

/cc Priyankasaggu11929
/assign Priyankasaggu11929

@Okabe-Junya
Copy link
Member Author

JFYI: I also updated in k-sigs/contributor-playground (diff)

@Priyankasaggu11929
Copy link
Member

Thank you, @Okabe-Junya.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Okabe-Junya, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1455b22 into kubernetes:master Oct 6, 2025
4 checks passed
@k8s-ci-robot
Copy link
Contributor

@Okabe-Junya: Updated the label-config configmap in namespace test-pods at cluster k8s-infra-prow-build-trusted using the following files:

  • key labels.yaml using file label_sync/labels.yaml

In response to this:

ref. kubernetes-sigs/contributor-playground#2177

What this PR does / why we need it:

  • to create some area/ labels for k-sigs/contributor-playground

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Okabe-Junya Okabe-Junya deleted the add-label/k-sigs-contributor-playground branch October 6, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/label_sync Issues or PRs related to code in /label_sync cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants