Skip to content

golang: Build 1.20rc1 images #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2022
Merged

golang: Build 1.20rc1 images #2816

merged 3 commits into from
Dec 14, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 13, 2022 •
edited by saschagrunert
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: Build 1.20rc1 images

also updates/cleanup:

  • drop 1.22 and go 1.16 build variants
  • update cosign image

/hold
/assign @saschagrunert @xmudrii @Verolop @palnabarun
cc @kubernetes/release-managers

Which issue(s) this PR fixes:

Related to #2815

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- drop 1.22 and go 1.16 build variants
- update cosign image
- golang: Build 1.20rc1 images

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2022
@saschagrunert saschagrunert changed the title golang: Build 1.19rc1 images golang: Build 1.20rc1 images Dec 13, 2022
@ameukam
Copy link
Member

ameukam commented Dec 13, 2022

/lgtm

xmudrii
xmudrii reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@cpanato cpanato mentioned this pull request Dec 13, 2022
Closed
34 tasks
xmudrii
xmudrii approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Dec 13, 2022

/test pull-release-image-releng-ci

@cpanato
Copy link
Member Author

cpanato commented Dec 13, 2022

/test pull-release-image-go-runner

@cpanato
Copy link
Member Author

cpanato commented Dec 14, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2022
@xmudrii
Copy link
Member

xmudrii commented Dec 14, 2022

Looks like a rate limit.
/retest

@cpanato
Copy link
Member Author

cpanato commented Dec 14, 2022

/test pull-release-image-releng-ci

@cpanato
Copy link
Member Author

cpanato commented Dec 14, 2022

/test pull-release-image-k8s-ci-builder

@cpanato
Copy link
Member Author

cpanato commented Dec 14, 2022

/test pull-release-image-go-runner

@cpanato
Copy link
Member Author

cpanato commented Dec 14, 2022

/test pull-release-image-kube-cross
/test pull-release-image-go-runner

@k8s-ci-robot k8s-ci-robot merged commit 542cb3f into kubernetes:master Dec 14, 2022
@cpanato cpanato deleted the go120 branch December 14, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@xmudrii xmudrii xmudrii approved these changes

@cici37 cici37 Awaiting requested review from cici37

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@palnabarun palnabarun

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cpanato @ameukam @k8s-ci-robot @xmudrii @saschagrunert @Verolop @palnabarun