go-mod support #169
Merged
go-mod support #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
liggitt
reviewed
Mar 21, 2019
k8s-ci-robot
added
size/XL
Merged
8 tasks
sttts
force-pushed
the
sttts-go-mod
branch
3 times, most recently
from
7800347 to
0faf320
Compare
This was referenced Mar 26, 2019
sttts
force-pushed
the
sttts-go-mod
branch
4 times, most recently
from
463a29a to
5bdc8a5
Compare
liggitt
reviewed
Apr 1, 2019
| go mod download | ||
|
|
||
| local pseudo_version=$(gomod-pseudo-version) | ||
| local cache_dir="${GOPATH}/pkg/mod/cache/download/${base_package}/${dep}/@v" |
There was a problem hiding this comment.
I'd be hesitant to modify the modcache directory with our own "fake published" module versions. Would it be possible to do something like this instead:
- run
go mod downloadon k/k to fetch all non-staging dependencies into the module cache - copy content of
${GOPATH}/pkg/mod/cache/downloadto/some/goproxy/dir - fake publish modules to
/some/goproxy/dir/${base_package}/${dep}/@v - run module operations with
GOPROXY=file:///some/goproxy/dir
sttts
force-pushed
the
sttts-go-mod
branch
2 times, most recently
from
734c97e to
165e3e7
Compare
liggitt
reviewed
Apr 1, 2019
sttts
force-pushed
the
sttts-go-mod
branch
3 times, most recently
from
aaed6dd to
dab0e92
Compare
liggitt
reviewed
Apr 3, 2019
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold until kubernetes/kubernetes#74877 merges. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes godeps support and adds generation of go.mod+sum. No vendor/ is generated anymore.
In parallel, there is a godeps branch forked off before this PR. We will keep running a second instance for all pre-1.15 versions.