Docker systemd: unifiy requires and wants

[medyagh]

build root waits for minikube-automount but docker doesn't

in buildroot.go

[Unit]
Description=Docker Application Container Engine
Documentation=https://docs.docker.com
After=network.target  minikube-automount.service docker.socket
Requires= minikube-automount.service docker.socket 

in ubuntu.go

[Unit]
Description=Docker Application Container Engine
Documentation=https://docs.docker.com
BindsTo=containerd.service
After=network-online.target firewalld.service containerd.service
Wants=network-online.target
Requires=docker.socket

[afbjorklund]

Note that minikube-automount is somewhat dangerous to run in the container.
i.e. it will start filling up the first partition from host, in my case that was /boot

Forgot that we did a special version of minikube-automount for kic

The problem with "network-online" is that we run into all systemd bugs with it...
But it would be nice to have a less special (i.e. old) setup for the ISO installation

More details in #6942

Otherwise sounds like #9231

[afbjorklund]

Also we shouldn't hack the default scripts, but do proper overrides instead.

Like when you do systemctl edit, creates a new file instead of editing old

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten