-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Fix test flake by increasing time out for verifying metrics for mirror pods #134499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Karthik-K-N The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-node-e2e-containerd-serial-ec2 |
/test pull-kubernetes-node-e2e-containerd-serial-ec2 |
1 similar comment
/test pull-kubernetes-node-e2e-containerd-serial-ec2 |
@Karthik-K-N: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind flake
What this PR does / why we need it:
We are expecting there should be no pods running during this test, In the previous fix #117000 its made sure thats valid.
I suspect there is some delay in metrics to be upto date.
The metrics validation is very aggressive here with only 5 seconds and where as other places in test where we call getKubeletMetrics waits for minimum of a minute. So waiting for more time should be able to fix this.
Which issue(s) this PR is related to:
Fixes #116998
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: