-
Notifications
You must be signed in to change notification settings - Fork 41.1k
[PodLevelResources] Verify scheduler resource metrics account for Pod Level Resources #132354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PodLevelResources] Verify scheduler resource metrics account for Pod Level Resources #132354
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @toVersus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @ndixita |
Signed-off-by: Tsubasa Nagasawa <[email protected]>
f93983c
to
d390902
Compare
/cc @sanposhiho @macsko @dom4ha |
/ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: a6602008273bb170b447b631d34866ee78e3bf38
|
/assign @kerthcet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerthcet, toVersus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is one of the PRs to enhance test coverage for KEP-2837: Pod Level Resources.
It adds a test to verify that
kube_pod_resource_request
andkube_pod_resource_limit
metrics exposed by the kube-scheduler correctly account for Pod Level Resources. The functionpodRequestsAndLimitsByLifecycle()
, which is used to retrieve the values of these metrics, has relied onPodRequests()
andPodLimits()
from k8s.io/component-helpers/resource since before KEP-2837 was implemented.With the implementation of KEP-2837 (#128407),
PodRequests()
andPodLimits()
now return values that take Pod Level Resources into account, so no changes were needed in the scheduler's code. While the added test cases are not exhaustive, I think they are sufficient to confirm that the metrics reflect the implementation of Pod Level Resources.Which issue(s) this PR is related to:
KEP: kubernetes/enhancements#2837
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: