Skip to content

[PodLevelResources] Verify scheduler resource metrics account for Pod Level Resources #132354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

toVersus
Copy link
Contributor

@toVersus toVersus commented Jun 17, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is one of the PRs to enhance test coverage for KEP-2837: Pod Level Resources.

It adds a test to verify that kube_pod_resource_request and kube_pod_resource_limit metrics exposed by the kube-scheduler correctly account for Pod Level Resources. The function podRequestsAndLimitsByLifecycle(), which is used to retrieve the values of these metrics, has relied on PodRequests() and PodLimits() from k8s.io/component-helpers/resource since before KEP-2837 was implemented.

With the implementation of KEP-2837 (#128407), PodRequests() and PodLimits() now return values that take Pod Level Resources into account, so no changes were needed in the scheduler's code. While the added test cases are not exhaustive, I think they are sufficient to confirm that the metrics reflect the implementation of Pod Level Resources.

Which issue(s) this PR is related to:

KEP: kubernetes/enhancements#2837

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/issues/2837

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @toVersus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from AxeZhan and damemi June 17, 2025 13:23
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 17, 2025
@toVersus
Copy link
Contributor Author

/cc @ndixita

@k8s-ci-robot k8s-ci-robot requested a review from ndixita June 17, 2025 13:24
@toVersus toVersus changed the title [PodLevelResources] Verify scheduler metrics account for Pod Level Resources [PodLevelResources] Verify scheduler resource metrics account for Pod Level Resources Jun 17, 2025
@toVersus
Copy link
Contributor Author

/cc @sanposhiho @macsko @dom4ha
I know you’re all busy with other high-priority tasks, but if any of you have some time, I’d really appreciate it if you could review this.

@AxeZhan
Copy link
Member

AxeZhan commented Jul 11, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 11, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2025
@AxeZhan
Copy link
Member

AxeZhan commented Jul 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6602008273bb170b447b631d34866ee78e3bf38

@ndixita
Copy link
Contributor

ndixita commented Jul 22, 2025

/assign @kerthcet

Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet, toVersus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit c1136ab into kubernetes:master Jul 22, 2025
12 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 22, 2025
@toVersus toVersus deleted the test/plr-scheduler-metrics branch July 22, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants