-
Notifications
You must be signed in to change notification settings - Fork 41.6k
Open
Labels
area/testkind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.sig/nodeCategorizes an issue or PR as relevant to SIG Node.Categorizes an issue or PR as relevant to SIG Node.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
We use features to indicate the environment that is "not standard" for e2e tests - i.e. requires extra configuration beyond feature gates.
This is uber issue to review sig-node features and clean them up:
- If the Feature is used to indicate just a "category" of tests - remove it
- If the Feature is used when FeatureGate must be used - replace with the FeatureGate
- If the Feature truly indicate a special environment, make sure it is well documented and corresponding test lanes are marked appropriately
Once we clear things up we may decide to pass the Feature as an argument for the test lane (similar to kubernetes/test-infra#35531 idea) and have more automated validation that the test requiring the Feature are only run in the test lane implementing this special environment
/sig node
/area test
/kind cleanup
/priority important-longterm
/cc @mariafromano-25 @esotsal
pacoxu, mariafromano-25 and esotsalesotsal
Metadata
Metadata
Assignees
Labels
area/testkind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.sig/nodeCategorizes an issue or PR as relevant to SIG Node.Categorizes an issue or PR as relevant to SIG Node.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Type
Projects
Status
Issues - In progress