Skip to content

Image promotion for build-image v1.25.0-go1.19rc2-bullseye.0 / v2.3.1-go1.19rc2-bullseye.0 #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2022
Merged

Image promotion for build-image v1.25.0-go1.19rc2-bullseye.0 / v2.3.1-go1.19rc2-bullseye.0 #3990

merged 2 commits into from
Jul 19, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jul 19, 2022 •
edited
Loading

Image promotion for build-image v1.25.0-go1.19rc2-bullseye.0 / v2.3.1-go1.19rc2-bullseye.0
This is an automated PR generated from kpromo

kpromo pr --fork palnabarun --interactive --project build-image --tag v1.25.0-go1.19rc2-bullseye.0 --tag v2.3.1-go1.19rc2-bullseye.0

Note: Manually edited the PR to include promotions that we only care about. The diff is larger because the recent dmap ordering changes.

/hold
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 19, 2022
@palnabarun
Copy link
Member Author

palnabarun commented Jul 19, 2022 •
edited
Loading

/wip

@palnabarun palnabarun force-pushed the build-image-v1.25.0-go1.19rc2-bullseye.0-image-promotion branch from 2568497 to e4134c3 Compare July 19, 2022 12:06
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 19, 2022
@palnabarun palnabarun mentioned this pull request Jul 19, 2022
Closed
40 tasks
@saschagrunert
Copy link
Member

@palnabarun can we either split-up the commits which change the ordering with them adding new content or just add the new content?

@palnabarun
Copy link
Member Author

@saschagrunert -- Thanks for the suggestions. I can do the split.

@palnabarun palnabarun force-pushed the build-image-v1.25.0-go1.19rc2-bullseye.0-image-promotion branch from e4134c3 to e2f6648 Compare July 19, 2022 13:59
saschagrunert
saschagrunert approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@palnabarun
Copy link
Member Author

Note for the future: the manifest grower grows manifests for the platform variants as well. We might need to revisit this logic as we have not been keeping those mappings up-to-date.

@palnabarun
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5e80c89 into kubernetes:main Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@puerco puerco Awaiting requested review from puerco

1 more reviewer

@saschagrunert saschagrunert saschagrunert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@palnabarun @saschagrunert @k8s-ci-robot