Adding feature to upgrade Oracle Cloud Infrastructure's Flexible Load Balancer and adjusting Health Check that were critical in the previous configuration

[josenetoo]

What this PR does / why we need it:

Oracle Cloud Infrastrucuture changed its Load balancer shape to flexible, and with that in the Oracle Cloud console it requested to update the Load balancer shape. And with that I added the lines to allow shape flex in the OCI Load balancer.

In addition to this update, I removed the "externalTrafficPolicy" line that was impacting the status of the health check Load balancer on Oracle Cloud.

With these two adjustments, I corrected the Load balancer shape and also the Health Check started responding correctly to the "OK" status in the Oracle Cloud console.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

How Has This Been Tested?

I performed several tests in Oracle Cloud environments to confirm the corrections, and if the Load Balancer with the nginx ingress controller was working perfectly.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Welcome @josenetoo!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @josenetoo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@josenetoo Thanks for this.

I am not able to test this because I don't have OCI account. If you can copy/paste the details of your test in enough granular info, then I think we can trust you because the changes are under the oci subdir, and merge this.

The other thing I have not checked is the use of kustomize. We generally generate the static manifest on each release, so you want to check if your change will persist across releases. I think this script generates the static manifests https://github.com/kubernetes/ingress-nginx/blob/main/hack/generate-deploy-scripts.sh . I saw someone comment that kustomize is not in use but the kustomize yaml is still in place.

If required, kindly rebase but does not look like there is any conflicting commit under oci dir.

[longwuyuan]

/triage accepted
cc @strongjz @rikatz @tao12345666333

[rikatz]

Isn't the manifest file generated?

[longwuyuan]

AFAIK yes, static yaml manifests are generated. I have not yet checked the changes since improvements like maze etc. So I have to check if kustimize or bash does the cloud specific unique specs in the OCI yaml manifest. I will comment after I check. But contributor also needs to check and alter PR accordingly, if required. Hence my response. Major aspect seems like cloud OCI changed something so our manifest needs to be updated, to work with that OCI change. Hoping updates from contributor will help make progress.

…

On Sun, 21 May, 2023, 5:16 pm Ricardo Katz, ***@***.***> wrote: Isn't the manifest file generated? — Reply to this email directly, view it on GitHub <#9961 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWXWBLDN4TD444NZ343XHH6BNANCNFSM6AAAAAAYAAFBYI> . You are receiving this because you commented.Message ID: ***@***.***>

[rikatz]

/ok-to-test
/lgtm
/approve

I don't have access to OCI, but if this works, it works :)

@josenetoo please just make sure the next release the change is still there, I can't remember if there is a need to persist this change somewhere else :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josenetoo, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment