Skip to content

Moving Instance Gateway to SIG-Network and renaming it #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

Moving Instance Gateway to SIG-Network and renaming it #8211

merged 1 commit into from
Dec 17, 2024

Conversation

robscott
Copy link
Member

New name will be gateway-api-inference-extension.

Which issue(s) this PR fixes:
None in this repo, but addresses kubernetes-sigs/gateway-api-inference-extension#41.

For more context on the name change, refer to the original proposal which has previously been discussed in SIG-Network, Instance Gateway, and Gateway API community meetings, as well as WG-Serving Slack and mailing list.

Looking for LGTM from representatives from each of the following groups:

SIG Apps Leads:
/cc @janetkuo @kow3ns @soltysh

SIG Net Leads:
/cc @aojea @danwinship @MikeZappa87 @shaneutt @thockin

WG Serving Leads:
/cc @ArangoGutierrez @Jeffwan @SergeyKanzhelev @terrytangyuan

/hold for consensus

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2024
@robscott
Moving Instance Gateway to SIG-Network and renaming it
d0a8320 
New name will be gateway-api-inference-extension.
@robscott robscott force-pushed the instance-gateway-move-and-rename branch from a39a011 to d0a8320 Compare December 10, 2024 20:49
soltysh
soltysh approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-apps pov

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2024
terrytangyuan
terrytangyuan reviewed Dec 10, 2024
View reviewed changes
@aojea
Copy link
Member

aojea commented Dec 10, 2024

/lgtm

This was presented during last sig network meeting with positive feedback

janetkuo
janetkuo approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MikeZappa87
Copy link
Contributor

/lgtm

@robscott robscott mentioned this pull request Dec 10, 2024
Closed
@terrytangyuan
Copy link
Member

/lgtm
/approve

@terrytangyuan terrytangyuan mentioned this pull request Dec 11, 2024
Merged
Jeffwan
Jeffwan approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, Jeffwan, robscott, soltysh, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt
Copy link
Member

/lgtm

@ahg-g
Copy link
Member

ahg-g commented Dec 16, 2024

Anything still blocking this PR?

@BenTheElder
Copy link
Member

IMHO: this could be unheld and a follow-up just to fix the name merged when the rename happens (pending kubernetes/org#5302 ...)

@MadhavJivrajani
Copy link
Contributor

I'm working on renaming the repo. Ideally, the rename in sigs.yaml would happen as part of that, but since this is already doing it, plase hold off on unholding the PR for now and I can unhold it once the rename is done!

@MadhavJivrajani MadhavJivrajani mentioned this pull request Dec 17, 2024
Merged
@MadhavJivrajani
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit d0bb2fe into kubernetes:master Dec 17, 2024
3 checks passed
BenTheElder
BenTheElder reviewed Dec 17, 2024
View reviewed changes
sigs.yaml
- name: gateway-api-inference-extension
description: Gateway API Inference Extension
owners:
- https://raw.githubusercontent.com/kubernetes-sigs/llm-instance-gateway/main/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fixup this link now that the repo was renamed?

(this link works, but we should use the canonical name)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8218

@robscott robscott mentioned this pull request Dec 17, 2024
Merged
@shaneutt shaneutt mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@danwinship danwinship Awaiting requested review from danwinship

@kow3ns kow3ns Awaiting requested review from kow3ns

@MikeZappa87 MikeZappa87 Awaiting requested review from MikeZappa87

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@shaneutt shaneutt Awaiting requested review from shaneutt

@thockin thockin Awaiting requested review from thockin

5 more reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@terrytangyuan terrytangyuan terrytangyuan left review comments

@soltysh soltysh soltysh approved these changes

@Jeffwan Jeffwan Jeffwan approved these changes

@janetkuo janetkuo janetkuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@terrytangyuan terrytangyuan

@Jeffwan Jeffwan

@janetkuo janetkuo

@shaneutt shaneutt

@aojea aojea

@MikeZappa87 MikeZappa87

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.