bump go version to 1.19+ #287
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go is currently on 1.24 / 1.23, 1.19 is old enough to still support back to Kubernetes 1.23 (10 releases behind the upcoming 1.33) switching to a newer go version gives us improvements to module management
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
Author
also, eventually we will want to use new language features, but I thought we should start conservatively, 1.13 is quite old |
Member
Author
|
/assign @jpbetz |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go is currently on 1.24 / 1.23, 1.19 is old enough to still support back to Kubernetes release-1.23 branch (10 releases behind the upcoming 1.33)
switching to a newer go version gives us improvements to module management
this is
go mod tidyafter bumping thegostatement to 1.19