Skip to content

Config option to disable hooks #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2022
Merged

Config option to disable hooks #871

merged 2 commits into from
Sep 26, 2022

Conversation

@fmuyassarov
Copy link
Member

Fixes: #859

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @fmuyassarov!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @fmuyassarov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok August 23, 2022 14:25
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 23, 2022
fmuyassarov
fmuyassarov commented Aug 23, 2022
View reviewed changes
@marquiz
Copy link
Contributor

marquiz commented Aug 23, 2022

ping @eero-t @mythi

@fmuyassarov fmuyassarov marked this pull request as ready for review August 24, 2022 07:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2022
eero-t
eero-t suggested changes Aug 24, 2022
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2022
eero-t
eero-t reviewed Aug 24, 2022
View reviewed changes
marquiz
marquiz requested changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov for this. Looks good, almost ready for merging. In addition to addressing the comment on logging, please run make templates so that the example config in the Helm chart also gets updated.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2022
@fmuyassarov fmuyassarov requested review from marquiz and removed request for adrianchiris, kad and zvonkok August 26, 2022 10:12
@fmuyassarov
Copy link
Member Author

Thanks @fmuyassarov for this. Looks good, almost ready for merging. In addition to addressing the comment on logging, please run make templates so that the example config in the Helm chart also gets updated.

/ok-to-test

Thanks, done.

marquiz
marquiz reviewed Aug 30, 2022
View reviewed changes
marquiz
marquiz approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov, good to merge from my point of view

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2022
@marquiz
Copy link
Contributor

marquiz commented Sep 1, 2022

Because enabling hooks opens potential NFD security hole [1], I think warning should be shown (also) when hooks are enabled.

I think we could print another note (possibly just an info/note, not a warning at this stage when hooksEnabled=true by default) in SetConfig. This would be printed whenever config is changed. Can be done in a separate PR, too

@fmuyassarov
Copy link
Member Author

/cc @zvonkok @ArangoGutierrez

@zvonkok
Copy link
Contributor

zvonkok commented Sep 1, 2022

On PTO will take a look next week.

@ArangoGutierrez
Copy link
Contributor

cc @yevgeny-shnaidman

@ArangoGutierrez
Copy link
Contributor

I like this PR
but since it introduces a deprecating change, let's go for more eyes
cc @zvonkok @yevgeny-shnaidman

ArangoGutierrez
ArangoGutierrez approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmuyassarov
Copy link
Member Author

/cc @Ethyling for lgtm :)

@zvonkok
Copy link
Contributor

zvonkok commented Sep 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8662d17 into kubernetes-sigs:master Sep 26, 2022
@fmuyassarov fmuyassarov deleted the disable-hook branch September 26, 2022 20:00
@marquiz marquiz mentioned this pull request Dec 20, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marquiz marquiz marquiz approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

+1 more reviewer

@eero-t eero-t eero-t requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zvonkok zvonkok

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Config option to disable hooks

6 participants

@fmuyassarov @k8s-ci-robot @marquiz @zvonkok @ArangoGutierrez @eero-t