Skip to content

Conversation

@camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Aug 24, 2024

The kubebuilder-release-tools project is no longer really maintained. The image required for checks is deprecated due
the infrastructure used to build and promote it be deprecated. Given the minimal nature of the check, it's unnecessary to maintain a GitHub Action for this purpose.

Also, it broke 1 day ago. Note that we need to pass permissions via GitHub Token, which is not very safe. This is another reason why we need to proceed with these changes.

When it fails:

Screenshot 2024-08-24 at 11 21 48

When the check pass:

Screenshot 2024-08-24 at 11 22 03

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-pr-tile branch 2 times, most recently from db4dec7 to 4979e43 Compare August 24, 2024 09:39
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2024
@camilamacedo86 camilamacedo86 force-pushed the fix-pr-tile branch 7 times, most recently from 7723e0a to 8b4487e Compare August 24, 2024 10:10
@camilamacedo86 camilamacedo86 changed the title ci: fix pr title verifier 🌱 (ci) - Fix the job to check the PR title and no longer use deprecated github action Aug 24, 2024
@camilamacedo86 camilamacedo86 marked this pull request as ready for review August 24, 2024 10:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Kavinjsir August 24, 2024 10:16
@camilamacedo86
Copy link
Member Author

Hi @sbueringer

We need to deprecate it in the kubebuilder tools repo
and communicate. I will try to move it in the follow up weeks
However, here's how we can achieve the same result without the action, which is actually safer, cleaner, and faster.

I will move with this one to fix our CI
but if you have suggestions please feel free to share and we can try to push in a follow up

@camilamacedo86 camilamacedo86 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 24, 2024
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2024
@camilamacedo86 camilamacedo86 merged commit 547b2f3 into kubernetes-sigs:master Aug 24, 2024
@camilamacedo86 camilamacedo86 deleted the fix-pr-tile branch August 24, 2024 10:23
camilamacedo86 added a commit to camilamacedo86/kubebuilder that referenced this pull request Aug 24, 2024
camilamacedo86 added a commit that referenced this pull request Aug 24, 2024
…hecker (#4097)

ci: Normalize text-based emoji codes to actual emojis in PR title checker

Follow up of: #4095
sarthaksarthak9 pushed a commit to sarthaksarthak9/kubebuilder that referenced this pull request Sep 9, 2024
…ed github action (kubernetes-sigs#4095)

The kubebuilder-release-tools project is no longer really maintained. The image required for checks is deprecated due
the infrastructure used to build and promote it be deprecated. Given the minimal nature of the check, it's unnecessary to maintain a GitHub Action for this purpose.

Also, it broke 1 day ago. Note that we need to pass permissions via GitHub Token, which is not very safe. This is another reason why we need to proceed with these changes.
sarthaksarthak9 pushed a commit to sarthaksarthak9/kubebuilder that referenced this pull request Sep 9, 2024
…hecker (kubernetes-sigs#4097)

ci: Normalize text-based emoji codes to actual emojis in PR title checker

Follow up of: kubernetes-sigs#4095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants