Skip to content

📖 fix kustomize-v2 index link #3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

📖 fix kustomize-v2 index link #3346

merged 1 commit into from
Apr 21, 2023

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Apr 21, 2023 •
edited
Loading

Description

Fix the kustomize v2 links on the left side.
Update info accordingly after plugin updates

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2023
@camilamacedo86 camilamacedo86 force-pushed the fix-kustomize-v2-index branch from 14cd492 to 81657ae Compare April 21, 2023 07:06
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2023
@camilamacedo86 camilamacedo86 force-pushed the fix-kustomize-v2-index branch from 81657ae to 1480580 Compare April 21, 2023 07:11
camilamacedo86
camilamacedo86 commented Apr 21, 2023
View reviewed changes
Copy link
Member Author

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving forward to fix the prod docs. Not a valuable effort to ask for a double review on this one since it is only nits.
We can also supplement or change it in follow-ups

@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2023
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-25-3
/test pull-kubebuilder-e2e-k8s-1-26-0

@k8s-ci-robot k8s-ci-robot merged commit 2a92f18 into kubernetes-sigs:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamacedo86 @k8s-ci-robot