Skip to content

🌱 : stop to generate all samples for go/v3 #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2023
Merged

🌱 : stop to generate all samples for go/v3 #3275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ee6e8b
:seedleing: stop to generate all samples for go/v3
camilamacedo86 Mar 11, 2023
837fcdc
Merge branch 'master' into stop-generate-testdata-v3
camilamacedo86 Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 4 additions & 9 deletions test/testdata/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,10 @@ build_kb
# [Deprecated] - Project version 2 uses plugin go/v2 (default).
scaffold_test_project project-v2 --project-version=2

# [Currently, default CLI plugin] - Project version 3 (default) uses plugin go/v3 (default).
scaffold_test_project project-v3 --plugins="go/v3"
scaffold_test_project project-v3-multigroup --plugins="go/v3"
scaffold_test_project project-v3-declarative-v1 --plugins="go/v3,declarative"
scaffold_test_project project-v3-config --component-config --plugins="go/v3"
scaffold_test_project project-v3-with-deploy-image --plugins="go/v3"
scaffold_test_project project-v3-with-grafana --plugins="go/v3"

# [Next version, alpha] Project version v4-alpha
# [Deprecated] - Project version 3 (default) uses plugin go/v3 (default).
scaffold_test_project project-v3

# [Currently, default CLI plugin] - [Next version, alpha] Project version v4-alpha
scaffold_test_project project-v4 --plugins="go/v4"
scaffold_test_project project-v4-multigroup --plugins="go/v4"
scaffold_test_project project-v4-declarative-v1 --plugins="go/v4,declarative"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we replicate the -with-deploy-image and -with-grafana samples for go/v4?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to expand the file to see that it already does 🤦 - ignore this

Expand Down
7 changes: 1 addition & 6 deletions test/testdata/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,8 @@ function test_project {

build_kb

# Test project v3
# Test project v3 [Deprecated]
test_project project-v3
test_project project-v3-multigroup
test_project project-v3-declarative-v1
test_project project-v3-config
test_project project-v3-with-deploy-image
test_project project-v3-with-grafana

# Project version v4-alpha
test_project project-v4
Expand Down
4 changes: 0 additions & 4 deletions testdata/project-v3-config/.dockerignore
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions testdata/project-v3-config/.gitignore
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions testdata/project-v3-config/Dockerfile
View file
Open in desktop

This file was deleted.

157 changes: 0 additions & 157 deletions testdata/project-v3-config/Makefile
View file
Open in desktop

This file was deleted.

53 changes: 0 additions & 53 deletions testdata/project-v3-config/PROJECT
View file
Open in desktop

This file was deleted.

Loading