Skip to content

✨ (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

✨ (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 #3085

merged 1 commit into from
Nov 21, 2022

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Nov 18, 2022 •
edited
Loading

Description

Upgrade controller-runtime version from 1.13.0 to 1.13.1

For further info, check the controller-runtime release notes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2022
@camilamacedo86 camilamacedo86 changed the title (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 ✨ (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 Nov 18, 2022
Kavinjsir
Kavinjsir approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

varshaprasad96
varshaprasad96 reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Do we need to bump anything in the docs? If not please feel free to approve and merge!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2022
everettraven
everettraven approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think we just need to override the failing checks? They seem to be expected failures

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven, Kavinjsir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 merged commit eddf0ad into kubernetes-sigs:master Nov 21, 2022
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Nov 21, 2022 •
edited
Loading

@varshaprasad96,

Do we need to bump anything in the docs? If not please feel free to approve and merge!

About this bump. I do not think so, Why should we? What motivates your question?

@camilamacedo86 camilamacedo86 deleted the bump-controller-runtime branch November 21, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 left review comments

+2 more reviewers

@Kavinjsir Kavinjsir Kavinjsir approved these changes

@everettraven everettraven everettraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@everettraven everettraven

@varshaprasad96 varshaprasad96

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@camilamacedo86 @k8s-ci-robot @Kavinjsir @everettraven @varshaprasad96