Skip to content

🐛: fixed bug for component-config flag #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

🐛: fixed bug for component-config flag #3010

merged 1 commit into from
Oct 10, 2022

Conversation

laxmikantbpandhare
Copy link
Contributor

@laxmikantbpandhare laxmikantbpandhare commented Oct 9, 2022 •
edited
Loading

There are 2 places where we must revert the sign which we missed as part of old PR #2826

{{- if not .ComponentConfig }}
        args:
        - --leader-elect
{{- end }}

it should be now modified to

{{- if .ComponentConfig }}
        args:
        - --leader-elect
{{- end }}

As of now, we are scaffolding the controller_manager_config.yaml file only when the flag --component-config is passed.

This fixes #3009

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2022
@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Oct 9, 2022
Closed
@laxmikantbpandhare
Copy link
Contributor Author

laxmikantbpandhare commented Oct 9, 2022 •
edited
Loading

@camilamacedo86 @everettraven @varshaprasad96 @jmrodri - PTAL

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2022
@laxmikantbpandhare
Copy link
Contributor Author

/assign @varshaprasad96

@laxmikantbpandhare laxmikantbpandhare mentioned this pull request Oct 9, 2022
Merged
2 tasks
everettraven
everettraven approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes makes sense to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022
jmrodri
jmrodri approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, jmrodri, laxmikantbpandhare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@jmrodri
Copy link
Contributor

jmrodri commented Oct 10, 2022

/approved

@k8s-ci-robot k8s-ci-robot merged commit 38ae383 into kubernetes-sigs:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

2 more reviewers

@jmrodri jmrodri jmrodri approved these changes

@everettraven everettraven everettraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmrodri jmrodri

@everettraven everettraven

@varshaprasad96 varshaprasad96

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Component-config flag enabled causing issue

5 participants

@laxmikantbpandhare @k8s-ci-robot @jmrodri @everettraven @varshaprasad96