Skip to content

Conversation

NikhilSharmaWe
Copy link
Contributor

Description

Added a note in deploy-image plugin documentation that users should keep in mind while running the operator locally.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2022
@NikhilSharmaWe NikhilSharmaWe force-pushed the docFix branch 3 times, most recently from a8046e7 to a96e58c Compare August 5, 2022 17:41
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2022
```

<aside class="note">
<h1> Running operator locally </h1>
Copy link
Member

@camilamacedo86 camilamacedo86 Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1> Running operator locally </h1>
<h1>Using make run</h1>

kubebuilder create api --group example.com --version v1alpha1 --kind Memcached --image=memcached:1.6.15-alpine --image-container-command="memcached,-m=64,modern,-v" --image-container-port="11211" --run-as-user="1001" --plugins="deploy-image/v1-alpha"
```

<aside class="note">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<aside class="note">
<aside class="warning">

<aside class="note">
<h1> Running operator locally </h1>

For running an operator made with deploy-image plugin locally, the envvar added in `config/manager/manager.yaml` which stores the value of the image needs to be exported before running the operator locally or out of the cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For running an operator made with deploy-image plugin locally, the envvar added in `config/manager/manager.yaml` which stores the value of the image needs to be exported before running the operator locally or out of the cluster.
The `make run` will execute the `main.go` outside of the cluster to let you test the project running it locally. Note that by using this plugin the Operand image informed will be stored via an environment variable in the `config/manager/manager.yaml` manifest.
Therefore, before run `make run` you need to export any environment variable that you might have. Example:
```sh
export MEMCACHED_IMAGE="memcached:1.4.36-alpine"

@NikhilSharmaWe NikhilSharmaWe force-pushed the docFix branch 3 times, most recently from 6f89248 to 59fc153 Compare August 6, 2022 14:43
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2022
@camilamacedo86
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7cd3532 into kubernetes-sigs:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants