Update the ListenerSet GEP per Kubecon discussions #4286
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| // and the ListenerSets's ParentRefs field. A ListenerSets is successfully attached to | ||
| // a Gateway when it is selected by the ListenerSets's AllowedListeners field | ||
| // AND the ListenerSets has a valid ParentRef selecting the Gateway | ||
| // resource as a parent resource. ListenerSets status does not impact |
There was a problem hiding this comment.
Uh, where did this come from? This is the complete opposite of how AttachedRoutes works, and basically defeats the point of having this number at all.
As described, this is basically "count of Listeners/ListenerSets that refer to this Gateway" rather than "count of ListenerSets that have successfully attached to the Gateway". The point here is to track the Listeners that have actually attached and are relevant, I thought.
There was a problem hiding this comment.
I was just making sure the GEP would reflect the API, but maybe this needs to be clarified on the API change first
3 participants
What type of PR is this?
/kind gep
What this PR does / why we need it:
This PR updates ListenerSet per Kubecon discussions on dynamic ports and attachedListenerSets. It also adds some more context on ListenerSet needs
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: