Conformance: Adds Port Response Header to Echo Server #4230
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
conformance/echo-basic/echo-basic.go
Outdated
| writeEchoResponseHeaders(w, r.Header) | ||
| // Optionally advertise the http port this process is serving. | ||
| if advertisePortHeader { | ||
| w.Header().Set("X-Echo-HTTP-Port", httpPort) |
There was a problem hiding this comment.
Instead of a response header, why not put this in the JSON response body like most other attributes? (I don't have a strong preference here, just trying to understand).
There was a problem hiding this comment.
I simply followed the pattern for echo'ing the pod ns, name, etc using headers. The latest commit adds the listening port to the response body, PTAL.
Signed-off-by: Daneyon Hansen <[email protected]>
- Required to support JSON-based echo response validation. Signed-off-by: Daneyon Hansen <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cc @rikatz @youngnick |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
4 participants
What type of PR is this?
/kind feature
/area conformance-machinery
What this PR does / why we need it:
Optionally adds a response header for the listening port of the echo server.
Which issue(s) this PR fixes:
Fixes #4229
Does this PR introduce a user-facing change?: