-
Notifications
You must be signed in to change notification settings - Fork 602
Bump BundleVersion to v1.4.0-rc.1 and add v1.4 CHANGELOG #4089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump BundleVersion to v1.4.0-rc.1 and add v1.4 CHANGELOG #4089
Conversation
Thanks @shaneutt! This LGTM. Doesn't need to be in this PR, but often in changelog PRs we also bump bundle version + the link to the PR where the release was reviewed by API reviewers. |
/cc |
488775f
to
8778689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaneutt!
fa7c0ff
to
5282c05
Compare
Signed-off-by: Shane Utt <[email protected]>
5282c05
to
bd3dd4f
Compare
Signed-off-by: Shane Utt <[email protected]>
Signed-off-by: Shane Utt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaneutt! Feel free to remove hold when you're ready to release.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
v1.4
CHANGELOGAlso includes
v1.4.0-rc.1
bump