ParentRefNotPermitted route reason in conformance test
#1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason ParentRefNotPermitted has been used and checked in the HTTPRouteInvalidCrossNamespaceParentRef conformance test. Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/S
mlavacca
changed the title
ParentRefNotPermitted route reason in conformance test
shaneutt
requested changes
Feb 2, 2023
conformance/tests/httproute-invalid-cross-namespace-parent-ref.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Shane Utt <[email protected]>
mlavacca
requested review from
shaneutt
and removed request for
howardjohn and
youngnick
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shaneutt
pushed a commit
that referenced
this pull request
Feb 7, 2023
…mance `ParentRefNotPermitted` route reason in conformance test
skriss
reviewed
Feb 7, 2023
shaneutt
added a commit
that referenced
this pull request
Feb 7, 2023
…d-conformance" This reverts commit 419ce85.
shaneutt
added a commit
to shaneutt/gateway-api
that referenced
this pull request
Feb 7, 2023
…ef-not-permitted-conformance" This reverts commit 419ce85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
When the
HTTPRouteis not accepted because the cross-namespaceparentRefis not granted, the specific reasonParentRefNotPermittedis used./kind feature
Which issue(s) this PR fixes:
Fixes #1688
Does this PR introduce a user-facing change?: