Some small cleanup from v0.6.0 review

apis/v1alpha2/gateway_types.go

@@ -60,10 +60,10 @@ type GatewaySpec = v1beta1.GatewaySpec
 type Listener = v1beta1.Listener
 
 // ProtocolType defines the application protocol accepted by a Listener.
-// Implementations are not required to accept all the defined protocols.
-// If an implementation does not support a specified protocol, it
-// should set the "Accepted" condition to "False" for the affected Listener with
-// a reason of "UnsupportedProtocol".
+// Implementations are not required to accept all the defined protocols. If an
+// implementation does not support a specified protocol, it MUST set the
+// "Accepted" condition to False for the affected Listener with a reason of
+// "UnsupportedProtocol".
 //
 // Core ProtocolType values are listed in the table below.
 //
@@ -470,9 +470,11 @@ const (
 	// This reason is used with the "ResolvedRefs" condition when the
 	// Listener has a TLS configuration with at least one TLS CertificateRef
 	// that is invalid or does not exist.
+	//
 	// A CertificateRef is considered invalid when it refers to a nonexistent
 	// or unsupported resource or kind, or when the data within that resource
 	// is malformed.
+	//
 	// This reason must be used only when the reference is allowed, either by
 	// referencing an object in the same namespace as the Gateway, or when
 	// a cross-namespace reference has been explicitly allowed by a ReferenceGrant.

apis/v1beta1/gateway_types.go

@@ -237,10 +237,10 @@ type Listener struct {
 }
 
 // ProtocolType defines the application protocol accepted by a Listener.
-// Implementations are not required to accept all the defined protocols.
-// If an implementation does not support a specified protocol, it
-// should set the "Accepted" condition for the affected Listener with
-// a reason of "UnsupportedProtocol".
+// Implementations are not required to accept all the defined protocols. If an
+// implementation does not support a specified protocol, it MUST set the
+// "Accepted" condition to False for the affected Listener with a reason of
+// "UnsupportedProtocol".
 //
 // Core ProtocolType values are listed in the table below.
 //

apis/v1beta1/httproute_types.go

@@ -439,13 +439,14 @@ type HTTPQueryParamMatch struct {
 	// entry with an equivalent name MUST be considered for a match. Subsequent
 	// entries with an equivalent query param name MUST be ignored.
 	//
-	// If a query param is repeated in an HTTP request, the behavior
-	// is purposely left undefined, since different data planes have different
-	// capabilities. However, it's *recommended* that implementations should
+	// If a query param is repeated in an HTTP request, the behavior is
+	// purposely left undefined, since different data planes have different
+	// capabilities. However, it is *recommended* that implementations should
 	// match against the first value of the param if the data plane supports it,
 	// as this behavior is expected in other load balancing contexts outside of
 	// the Gateway API.
-	// Users should not route traffic based on repeated query params to guard
+	//
+	// Users SHOULD NOT route traffic based on repeated query params to guard
 	// themselves against potential differences in the implementations.
 	//
 	// +kubebuilder:validation:MinLength=1
@@ -722,11 +723,10 @@ type HTTPHeader struct {
 
 // HTTPHeaderFilter defines a filter that modifies the headers of an HTTP
 // request or response. Only one action for a given header name is permitted.
-// Filters specifying multiple actions of the same or different type for
-// any one header name are invalid and will be rejected by the webhook if
-// installed. Configuration to set or add multiple values for a
-// header must use RFC 7230 header value formatting, separating each value with
-// a comma.
+// Filters specifying multiple actions of the same or different type for any one
+// header name are invalid and will be rejected by the webhook if installed.
+// Configuration to set or add multiple values for a header must use RFC 7230
+// header value formatting, separating each value with a comma.
 type HTTPHeaderFilter struct {
 	// Set overwrites the request with the given header (name, value)
 	// before the action.
@@ -861,11 +861,8 @@ type HTTPPathModifier struct {
 // HTTPRequestRedirect defines a filter that redirects a request. This filter
 // MUST NOT be used on the same Route rule as a HTTPURLRewrite filter.
 type HTTPRequestRedirectFilter struct {
-	// Scheme is the scheme to be used in the value of the `Location`
-	// header in the response.
-	// When empty, the scheme of the request is used.
-	//
-	// Support: Extended
+	// Scheme is the scheme to be used in the value of the `Location` header in
+	// the response. When empty, the scheme of the request is used.
 	//
 	// Note that values may be added to this enum, implementations
 	// must ensure that unknown values will not cause a crash.
@@ -874,6 +871,8 @@ type HTTPRequestRedirectFilter struct {
 	// Accepted Condition for the Route to `status: False`, with a
 	// Reason of `UnsupportedValue`.
 	//
+	// Support: Extended
+	//
 	// +optional
 	// +kubebuilder:validation:Enum=http;https
 	Scheme *string `json:"scheme,omitempty"`
@@ -908,15 +907,15 @@ type HTTPRequestRedirectFilter struct {
 
 	// StatusCode is the HTTP status code to be used in response.
 	//
-	// Support: Core
-	//
 	// Note that values may be added to this enum, implementations
 	// must ensure that unknown values will not cause a crash.
 	//
 	// Unknown values here must result in the implementation setting the
 	// Accepted Condition for the Route to `status: False`, with a
 	// Reason of `UnsupportedValue`.
 	//
+	// Support: Core
+	//
 	// +optional
 	// +kubebuilder:default=302
 	// +kubebuilder:validation:Enum=301;302

apis/v1beta1/referencegrant_types.go

@@ -63,9 +63,9 @@ type ReferenceGrantList struct {
 // for Gateway API.
 type ReferenceGrantSpec struct {
 	// From describes the trusted namespaces and kinds that can reference the
-	// resources described in "To". Each entry in this list must be considered
+	// resources described in "To". Each entry in this list MUST be considered
 	// to be an additional place that references can be valid from, or to put
-	// this another way, entries must be combined using OR.
+	// this another way, entries MUST be combined using OR.
 	//
 	// Support: Core
 	//
@@ -74,9 +74,9 @@ type ReferenceGrantSpec struct {
 	From []ReferenceGrantFrom `json:"from"`
 
 	// To describes the resources that may be referenced by the resources
-	// described in "From". Each entry in this list must be considered to be an
+	// described in "From". Each entry in this list MUST be considered to be an
 	// additional place that references can be valid to, or to put this another
-	// way, entries must be combined using OR.
+	// way, entries MUST be combined using OR.
 	//
 	// Support: Core
 	//

apis/v1beta1/shared_types.go

@@ -351,9 +351,9 @@ type RouteStatus struct {
 // Hostname is the fully qualified domain name of a network host. This matches
 // the RFC 1123 definition of a hostname with 2 notable exceptions:
 //
-//  1. IPs are not allowed.
-//  2. A hostname may be prefixed with a wildcard label (`*.`). The wildcard
-//     label must appear by itself as the first label.
+// 1. IPs are not allowed.
+// 2. A hostname may be prefixed with a wildcard label (`*.`). The wildcard
+//    label must appear by itself as the first label.
 //
 // Hostname can be "precise" which is a domain name without the terminating
 // dot of a network host (e.g. "foo.example.com") or "wildcard", which is a