Skip to content

Conversation

@robscott
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This cherry picks the following PRs into the release-0.5 branch:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2022
mlavacca and others added 2 commits September 19, 2022 21:33
A new conformance test case has been added to ensure that whenever a
listener references an unexisting secret as CertificateRef, the
Condition ResolvedRefs is set as failed with reason
InvalidCertificateRef.

Signed-off-by: Mattia Lavacca <[email protected]>
* apis/v1alpha2/object_reference_types.go (BackendObjectReference):
* apis/v1beta1/object_reference_types.go (BackendObjectReference): Clarify
that the Port field references the service port number when the backend
is a Kubernetes Service.
* config/crd/experimental/gateway.networking.k8s.io_grpcroutes.yaml:
* config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml:
* config/crd/experimental/gateway.networking.k8s.io_tcproutes.yaml:
* config/crd/experimental/gateway.networking.k8s.io_tlsroutes.yaml:
* config/crd/experimental/gateway.networking.k8s.io_udproutes.yaml:
* config/crd/standard/gateway.networking.k8s.io_httproutes.yaml:
Regenerate.
@robscott robscott added this to the v0.5.1 milestone Sep 19, 2022
@shaneutt shaneutt self-requested a review September 19, 2022 22:22
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d4d3bcb into kubernetes-sigs:release-0.5 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants