Release 0.5.0 contains duplicate kind:Namespace/gateway-system object definition.

[eigood]

I'm attempting to reference either the standard-install.yaml or experimental-install.yaml on the releases page, via a kustomization.yaml/resources: tag. However, both of those files contain a duplicate definition of the gateway-system namespace. This breaks when applied directly via using via helmfile/helm/kustomize pipeline.

To work around this I downloaded the files and I modified them locally, to remove the duplicate Namespace.

[tokers]

What do you mean by saying a duplicate definition of the gateway-system? A re-defintion for Kubernetes namespace?

[robscott]

It looks like the problem is that both config/webhook/certificate_config.yaml and config/webhook/admission_webhook.yaml include the namespace definition. We concatenate those files together here:

gateway-api/hack/build-install-yaml.sh

Lines 42 to 58 in 83eac3a

	for file in `ls config/webhook/*.yaml config/crd/experimental/gateway*.yaml`
	do
	echo "---" >> release/experimental-install.yaml
	echo "#" >> release/experimental-install.yaml
	echo "# $file" >> release/experimental-install.yaml
	echo "#" >> release/experimental-install.yaml
	cat $file >> release/experimental-install.yaml
	done
	for file in `ls config/webhook/*.yaml config/crd/standard/*.yaml`
	do
	echo "---" >> release/standard-install.yaml
	echo "#" >> release/standard-install.yaml
	echo "# $file" >> release/standard-install.yaml
	echo "#" >> release/standard-install.yaml
	cat $file >> release/standard-install.yaml
	done

.

I don't think we're suggesting anyone use the individual YAML files, so it may make sense to pull out the namespace definition to a separate 0-namespace.yaml file.

[gyohuangxin]

@robscott I'm interesting in contributing to gateway-api project and I think this issue is a good start, can you assign it to me? Thanks.

[robscott]

Thanks!

/assign @gyohuangxin

[gyohuangxin]

@robscott Thanks, I just created a PR, can you review it?

[robscott]

Opening this back up to track a cherry pick into release-0.5

[gyohuangxin]

@robscott I raised a PR to cherry pick it into release-0.5, please review it, thanks.