Skip to content

Conversation

keithmattix
Copy link
Contributor

Expands on #615 to update the host for the model service being referenced in the quickstart

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong June 10, 2025 22:13
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7fb5748
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6848adf114ab640008a01e72
😎 Deploy Preview https://deploy-preview-958--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@LiorLieberman
Copy link
Member

Thanks @keithmattix!

@kfswain I think this is due to #578.

Any recommendation how we make sure references to the EPP manifests are updated before making more changes as we go GA.

@LiorLieberman
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
@keithmattix
Copy link
Contributor Author

It might make sense to template these manifests in some way so that model references can be standardized. We could then generate the appropriate files for QuickStart documentation

@nirrozenbaum
Copy link
Contributor

/lgtm

Thanks Keith!

@ahg-g
Copy link
Contributor

ahg-g commented Jun 11, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, keithmattix, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit dad0616 into kubernetes-sigs:main Jun 11, 2025
8 checks passed
@keithmattix keithmattix deleted the fix-destinationrule branch June 11, 2025 18:02
@danehans
Copy link
Contributor

It might make sense to template these manifests in some way so that model references can be standardized. We could then generate the appropriate files for QuickStart documentation

@keithmattix do you mind creating an issue for ^?

rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants