-
Notifications
You must be signed in to change notification settings - Fork 182
Fix the DestinationRule's referenced model service name #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the DestinationRule's referenced model service name #958
Conversation
Signed-off-by: Keith Mattix II <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thanks @keithmattix! @kfswain I think this is due to #578. Any recommendation how we make sure references to the EPP manifests are updated before making more changes as we go GA. |
/approve |
It might make sense to template these manifests in some way so that model references can be standardized. We could then generate the appropriate files for QuickStart documentation |
/lgtm Thanks Keith! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, keithmattix, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@keithmattix do you mind creating an issue for ^? |
…igs#958) Signed-off-by: Keith Mattix II <[email protected]>
…igs#958) Signed-off-by: Keith Mattix II <[email protected]>
Expands on #615 to update the host for the model service being referenced in the quickstart