Skip to content

Fix typos and lint errors to pass golangci-lint #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2025
Merged

Fix typos and lint errors to pass golangci-lint #902

merged 2 commits into from
Jun 1, 2025

Conversation

shotarok
Copy link
Contributor

@shotarok shotarok commented May 31, 2025 •
edited
Loading

Fixes #901

Fix typos and lint errors to pass golangcli-lint.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2025
@netlify Netlify
Copy link

netlify bot commented May 31, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 094f10c
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/683a8fced99da50008a3fe1a
😎 Deploy Preview https://deploy-preview-902--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 31, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @shotarok. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2025
@shotarok shotarok changed the title Fix typos to pass golangci-lint Fix typos and lint errors to pass golangci-lint May 31, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2025
@shotarok
Copy link
Contributor Author

/assign arangogutierrez

@nirrozenbaum
Copy link
Contributor

cc @ahg-g @danehans

@ahg-g
Copy link
Contributor

ahg-g commented Jun 1, 2025

/approve

not sure if we want to exclude the docs pkg altogether from the linter

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, shotarok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit f0310dc into kubernetes-sigs:main Jun 1, 2025
6 of 7 checks passed
@danehans danehans mentioned this pull request Jun 2, 2025
Merged
irar2 pushed a commit to irar2/gateway-api-inference-extension that referenced this pull request Jun 3, 2025
@shotarok @irar2
Fix typos and lint errors to pass golangci-lint (kubernetes-sigs#902)
469e27f 
* recieves -> receives

* Allow unused variables for a proposal doc
shmuelk pushed a commit to shmuelk/gateway-api-inference-extension that referenced this pull request Jun 3, 2025
@shotarok @shmuelk
Fix typos and lint errors to pass golangci-lint (kubernetes-sigs#902)
b36fb3f 
* recieves -> receives

* Allow unused variables for a proposal doc
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
@shotarok @rlakhtakia
Fix typos and lint errors to pass golangci-lint (kubernetes-sigs#902)
827f35b 
* recieves -> receives

* Allow unused variables for a proposal doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

@robscott robscott Awaiting requested review from robscott

Assignees

@ArangoGutierrez ArangoGutierrez

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Job Failures Due to PR 845

5 participants

@shotarok @k8s-ci-robot @nirrozenbaum @ahg-g @ArangoGutierrez