Skip to content

Optimize Dockerfile for Multiple Extensions #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Optimize Dockerfile for Multiple Extensions #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ COPY go.mod go.sum ./
RUN go mod download

# Sources
COPY cmd ./cmd
COPY pkg ./pkg
COPY cmd/epp ./cmd
COPY pkg/epp ./pkg/epp
COPY internal ./internal
COPY api ./api
WORKDIR /src/cmd/epp
WORKDIR /src/cmd
RUN go build -ldflags="-X sigs.k8s.io/gateway-api-inference-extension/pkg/epp/metrics.CommitSHA=${COMMIT_SHA}" -o /epp

## Multistage deploy
Expand Down
4 changes: 2 additions & 2 deletions bbr.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ COPY go.mod go.sum ./
RUN go mod download

# Sources
COPY cmd ./cmd
COPY cmd/bbr ./cmd
COPY pkg ./pkg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying the complete package here, because bbr needs the following packages
handlers/server.go:30: logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
handlers/server.go:31: requtil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/request"

I can copy these individually, but the same might not look clean. Hence, copying in the complete package,
@danehans , please let me know, if I have update this copy only individual directories.
Thank you!

COPY internal ./internal
WORKDIR /src/cmd/bbr
WORKDIR /src/cmd
RUN go build -o /bbr

## Multistage deploy
Expand Down