Skip to content

Conversation

@nirrozenbaum
Copy link
Contributor

this PR fix a bug in cloning the pod's labels.
the bug was that labels value is assigned from one map to another.
this copies a pointer to the map (both vars are sharing the map), two problems with that:

  1. if the map will change due to pod labels change and reconcile event at the same time a plugin access that map with no locking mechanism, it may cause issues (read & write in parallel to labels map without sync).
  2. pod's labels may change during the scheduling cycle which is no good cause it may cause inconsistencies in the scheduler plugins.

this PR clones the labels to fix it.

Signed-off-by: Nir Rozenbaum <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and ahg-g May 8, 2025 19:09
@netlify
Copy link

netlify bot commented May 8, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit bdb8d1e
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/681d015ff80b7600085fa6dc
😎 Deploy Preview https://deploy-preview-804--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2025
@ahg-g
Copy link
Contributor

ahg-g commented May 8, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2025
@nirrozenbaum
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 2b66451 into kubernetes-sigs:main May 8, 2025
8 checks passed
@nirrozenbaum nirrozenbaum deleted the clone-labels branch May 8, 2025 21:26
nayihz pushed a commit to nayihz/gateway-api-inference-extension that referenced this pull request May 14, 2025
kaushikmitr pushed a commit to kaushikmitr/llm-instance-gateway that referenced this pull request May 15, 2025
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants