Fix build and test #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
liu-cong
commented
Dec 4, 2024
liu-cong
commented
- Fix a bug in main and a couple tests
- Adjust the logging level to be consistent with the rest: use V(3) for request level info logs.
k8s-ci-robot
added
cncf-cla: yes
liu-cong
commented
Dec 4, 2024
| modelObj := s.datastore.FetchModelData(model) | ||
| if modelObj != nil && len(modelObj.TargetModels) > 0 { | ||
| modelName = backend.RandomWeightedDraw(modelObj) | ||
| modelName = backend.RandomWeightedDraw(modelObj, 0) |
There was a problem hiding this comment.
This is the bug, missing the seed value argument
| return resp, nil | ||
| } | ||
|
|
||
| func (s *Server) FetchModelData(modelName string) (returnModel *v1alpha1.Model) { |
There was a problem hiding this comment.
Moved to datastore for better encapsulation. Also makes it easier to fake the datastore in tests.
|
/approve thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, liu-cong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.