Skip to content

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Apr 1, 2025

Moving to FULL DUPLEX STREAM as the default, and updating the base model + LoRA adapter caused the e2e tests to fall out of sync.

Fixes: #619

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2025
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit aefb78a
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67ec401174860200089d1f5b
😎 Deploy Preview https://deploy-preview-636--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Apr 1, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 110f490 into kubernetes-sigs:main Apr 1, 2025
8 checks passed
@kfswain kfswain deleted the test-fix branch April 21, 2025 20:56
kfswain added a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
kfswain added a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
kfswain added a commit to kfswain/llm-instance-gateway that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests broken
3 participants