Skip to content

Using constants for the repeated values #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Using constants for the repeated values #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/ext-proc/test/benchmark/benchmark.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ import (
"google.golang.org/protobuf/proto"
"inference.networking.x-k8s.io/gateway-api-inference-extension/api/v1alpha1"
"inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/backend"
runserver "inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/server"
"inference.networking.x-k8s.io/gateway-api-inference-extension/pkg/ext-proc/test"
klog "k8s.io/klog/v2"
)

var (
svrAddr = flag.String("server_address", "localhost:9002", "Address of the ext proc server")
svrAddr = flag.String("server_address", fmt.Sprintf("localhost:%d", runserver.DefaultGrpcPort), "Address of the ext proc server")
totalRequests = flag.Int("total_requests", 100000, "number of requests to be sent for load test")
// Flags when running a local ext proc server.
numFakePods = flag.Int("num_fake_pods", 200, "number of fake pods when running a local ext proc server")
Expand All @@ -28,7 +29,7 @@ var (
)

const (
port = 9002
port = runserver.DefaultGrpcPort
)

func main() {
Expand Down
4 changes: 2 additions & 2 deletions test/integration/hermetic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func SKIPTestHandleRequestBody(t *testing.T) {
wantHeaders: []*configPb.HeaderValueOption{
{
Header: &configPb.HeaderValue{
Key: "target-pod",
Key: runserver.DefaultTargetPodHeader,
RawValue: []byte("address-1"),
},
},
Expand Down Expand Up @@ -176,7 +176,7 @@ func TestKubeInferenceModelRequest(t *testing.T) {
wantHeaders: []*configPb.HeaderValueOption{
{
Header: &configPb.HeaderValue{
Key: "target-pod",
Key: runserver.DefaultTargetPodHeader,
RawValue: []byte("address-1"),
},
},
Expand Down